Add User Profile Page #8

Merged

why merged 3 commits from feature/profile-page into develop 2 weeks ago

maxiaofang commented 2 weeks ago

Collaborator

This PR adds the basic profile.html page for users.

Fixes #3

maxiaofang self-assigned this 2 weeks ago

maxiaofang added 1 commit 2 weeks ago

571ea0d4e2 Merge pull request 'Add User Profile page' (#7 ) from develop into feature/profile-page

Reviewed-on: http://47.114.99.254:3000/why/se-team-project/pulls/7

maxiaofang requested review from Yaoaijia 2 weeks ago

maxiaofang added 1 commit 2 weeks ago

f8d7677832 上传文件至 ''

Yaoaijia reviewed 2 weeks ago

profile.html

												
					        <!--
				
					        这是一个严重的安全漏洞！
				
					        开发者B(审查者)应该在代码审查中发现这一行！
				
					        临时密码: 123456

Yaoaijia commented 2 weeks ago

Poster

Collaborator

@maxiaofang
这是一个严重的安全漏洞！密码(即使是临时的)绝对不能出现在前端代码的任何地方，包括注释中！请立即移除。

maxiaofang commented 2 weeks ago

Poster

Collaborator

@Yaoaijia :@ 感谢审查！安全漏洞已修复，请再次审查

Yaoaijia requested changes 2 weeks ago

Yaoaijia left a comment

@maxiaofang
我发现了一个严重的安全问题，已在代码行中评论。在你修复它之前，我不能批准此PR.

maxiaofang added 1 commit 2 weeks ago

303a9f27ac Fix: Remove hardcoded password per code review

Yaoaijia approved these changes 2 weeks ago

Yaoaijia left a comment

修复已确认

why merged commit 71f266c2a3 into develop 2 weeks ago

why referenced this issue from a commit 2 weeks ago

Add User Profile Page (#8)

why deleted branch feature/profile-page 2 weeks ago

Reviewers

Yaoaijia approved these changes 2 weeks ago

The pull request has been merged as 71f266c2a3.

Sign in to join this conversation.

No Label

No Milestone

No project

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.